Add route options to routing loader #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add some docs and tests? thank you |
|
ok? |
|
@havvg whats your opinion on this? |
| @@ -250,6 +251,10 @@ Each filter set that you specify has the following options: | |||
| - `cache` - override the default cache setting | |||
| - `data_loader` - override the default data loader | |||
| - `controller_action` - override the default controller action | |||
| - `route` - optional list of route requirements, defaults and options using in the route loader. Add array width keys 'requirements', 'defaults' or 'options'. | |||
There was a problem hiding this comment.
Typo: Add array width should be Add array with
|
Looks good to me. I commented some clean up issues. This could also avoid some DoS when using dynamic variables in filter routes. |
|
ok? |
havvg
added a commit
that referenced
this pull request
Feb 8, 2013
Add route options to routing loader
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add route options to routing loader